diff --git a/fsl/utils/filetree/filetree.py b/fsl/utils/filetree/filetree.py index 3159fefa842f986115921ae4166df7411ac93893..44f2b7b15ff951e410686e87769728194db55d29 100644 --- a/fsl/utils/filetree/filetree.py +++ b/fsl/utils/filetree/filetree.py @@ -354,7 +354,7 @@ class FileTree(object): self.variables = {} @classmethod - def read(cls, tree_name: str, directory='.', partial_fill=True, **variables) -> "FileTree": + def read(cls, tree_name: str, directory='.', partial_fill=False, **variables) -> "FileTree": """ Reads a FileTree from a specific file diff --git a/fsl/utils/filetree/query.py b/fsl/utils/filetree/query.py index a2e215c848558f304e62c61ba529614bd05038f0..d371bcdf37a7d31d7ed333e602ba50f992477ade 100644 --- a/fsl/utils/filetree/query.py +++ b/fsl/utils/filetree/query.py @@ -89,6 +89,8 @@ class FileTreeQuery(object): :arg tree: The :class:`.FileTree` object """ + # Hard-code into the templates any pre-defined variables + tree = tree.partial_fill() # Find all files present in the directory # (as Match objects), and find all variables, diff --git a/tests/test_filetree/test_read.py b/tests/test_filetree/test_read.py index 6627969e343094ca8a8cc8797c09872195ab9774..0ceaa5086ce70bdcabaf91416c27b27d762429e7 100644 --- a/tests/test_filetree/test_read.py +++ b/tests/test_filetree/test_read.py @@ -13,14 +13,21 @@ def same_path(p1, p2): def test_simple_tree(): tree = filetree.FileTree.read('eddy') - assert 'basename' not in tree.variables + assert 'basename' in tree.variables same_path(tree.get('basename'), './eddy_output') same_path(tree.get('image'), './eddy_output.nii.gz') + same_path(tree.update(basename='eddy').get('image'), './eddy.nii.gz') tree = filetree.FileTree.read('eddy.tree', basename='out') + assert 'basename' in tree.variables + same_path(tree.get('basename'), './out') + same_path(tree.update(basename='eddy').get('image'), './eddy.nii.gz') + + tree = filetree.FileTree.read('eddy.tree', basename='out', partial_fill=True) assert 'basename' not in tree.variables same_path(tree.get('basename'), './out') + same_path(tree.update(basename='eddy').get('image'), './out.nii.gz') with pytest.raises(ValueError): filetree.FileTree.read('non_existing')