From 5d75103ba8e82d3f132ebc3a049a1c12dce2174d Mon Sep 17 00:00:00 2001
From: Michiel Cottaar <michiel.cottaar@ndcn.ox.ac.uk>
Date: Wed, 21 Feb 2024 17:03:58 +0000
Subject: [PATCH] By default oversample with a factor of 2
---
src/parts/helper_functions.jl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/parts/helper_functions.jl b/src/parts/helper_functions.jl
index 95e6e34..cfa53cd 100644
--- a/src/parts/helper_functions.jl
+++ b/src/parts/helper_functions.jl
@@ -141,7 +141,7 @@ Adds a readout event to the sequence.
- `optimise`: Whether to optimise this readout event in isolation from the rest of the sequence. Use this with caution. It can speed up the optimisation (and for very complicated sequences make it more robust), however the resulting parameters might not represent the optimal solution of any external constraints (which are ignored if the readout is optimised in isolation).
- `scanner`: Used for testing. Do not set this parameter at this level (instead set it for the total sequence using [`build_sequence`](@ref)).
"""
-function readout_event(; type=nothing, optimise=false, scanner=nothing, all_variables...)
+function readout_event(; type=nothing, optimise=false, scanner=nothing, oversample=2, all_variables...)
real_variables = Dict(key => value for (key, value) in pairs(all_variables) if !(isnothing(value) || (value isa AbstractVector && all(isnothing.(value)))))
if isnothing(type)
resolution = get(real_variables, :resolution, nothing)
@@ -149,6 +149,7 @@ function readout_event(; type=nothing, optimise=false, scanner=nothing, all_vari
end
if type == :instant
optimise = false # there is nothing to optimise
+ oversample = nothing
end
build_sequence(scanner; optimise=optimise) do
func_dict = Dict(
@@ -158,7 +159,7 @@ function readout_event(; type=nothing, optimise=false, scanner=nothing, all_vari
if !(type in keys(func_dict))
error("Readout event type `$type` has not been implemented. Please use one of $(keys(func_dict)).")
end
- return func_dict[type](; real_variables...)
+ return func_dict[type](; oversample=oversample, real_variables...)
end
end
--
GitLab