From a65c6fb50034d29bb62fc81f46c6630e144452bb Mon Sep 17 00:00:00 2001
From: Michiel Cottaar <michiel.cottaar@ndcn.ox.ac.uk>
Date: Tue, 30 Jan 2024 15:35:54 +0000
Subject: [PATCH] Use default qval function for pathways
---
src/pathways.jl | 11 -----------
src/variables.jl | 4 ++--
2 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/src/pathways.jl b/src/pathways.jl
index 3456990..d9a2119 100644
--- a/src/pathways.jl
+++ b/src/pathways.jl
@@ -126,17 +126,6 @@ You can set `scale` and/or `rotate` to specific symbols to only consider gradien
"""
qvec(pathway::Pathway; scale=nothing, rotate=nothing) = get(pathway.qvec, (scale, rotate), zero(SVector{3, Float64}))
-"""
- qval(pathway::Pathway; scale=nothing, rotate=nothing)
-
-Return net displacement in k-space/q-space experienced by the spins following a specific [`Pathway`](@ref).
-
-Only gradients active while the spins are in the transverse plane are considered.
-
-By default gradients that are affected by user-provided `scale` or `rotate` parameters (e.g., bvals/bvecs) are ignored.
-You can set `scale` and/or `rotate` to specific symbols to only consider gradients that are affected by speficic `scale`/`rotate` parameters
-"""
-qval(pathway::Pathway; scale=nothing, rotate=nothing) = norm(qvec(pathway; scale, rotate))
"""
area_under_curve(pathway::Pathway; scale=nothing, rotate=nothing)
diff --git a/src/variables.jl b/src/variables.jl
index a4a0287..6014cd0 100644
--- a/src/variables.jl
+++ b/src/variables.jl
@@ -53,8 +53,8 @@ variables() = [values(symbol_to_func)...]
# Some universal truths
-function qval(bb)
- vec = qvec(bb)
+function qval(bb; kwargs...)
+ vec = qvec(bb; kwargs...)
return sqrt(vec[1]^2 + vec[2]^2 + vec[3]^2)
end
--
GitLab