From 0bfa011b471f9cdc421aab74ba3a10e885de26c1 Mon Sep 17 00:00:00 2001
From: Peter Mosses <18308236+pdmosses@users.noreply.github.com>
Date: Tue, 27 Dec 2022 18:46:18 +0100
Subject: [PATCH] Avoid Liquid failure with empty collections (#1092)
Avoid Liquid failure when no pages with titles
Fix issue #1085
The user's config specified collections (incorrectly). Trying to build the site resulted in Jekyll failing due to a Liquid error. The error report did not suggest the cause of the error.
Liquid fails with division by 0 when title_pages_size is 0. This fix guards that code by checking that title_pages is non-empty.
To test:
1. Specify a Jekyll collection with no pages, and specify it as a JTD collection.
2. Build the site.
3. Check that the specified collection has no nav links to pages.
---
_includes/nav.html | 32 +++++++++++++++++---------------
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/_includes/nav.html b/_includes/nav.html
index 834662a8..8636e571 100644
--- a/_includes/nav.html
+++ b/_includes/nav.html
@@ -39,21 +39,23 @@
pages.
{%- endcomment -%}
-{%- assign unsorted_pages = title_pages
- | where_exp: "item", "item.parent == nil"
- | where_exp: "item", "item.nav_exclude == true"-%}
-{%- assign title_pages_size = title_pages.size -%}
-{%- assign unsorted_pages_percent = unsorted_pages.size
- | times: 100 | divided_by: title_pages_size -%}
-{%- if unsorted_pages_percent > 50 -%}
- {%- assign sorted_pages = "" | split: "" -%}
- {%- for item in title_pages -%}
- {%- if item.nav_exclude != true or item.parent -%}
- {%- assign sorted_pages = sorted_pages | push: item -%}
- {%- endif -%}
- {%- endfor -%}
- {%- assign title_pages = sorted_pages -%}
-{%- endif -%}
+{%- unless title_pages == empty -%}
+ {%- assign unsorted_pages = title_pages
+ | where_exp: "item", "item.parent == nil"
+ | where_exp: "item", "item.nav_exclude == true" -%}
+ {%- assign title_pages_size = title_pages.size -%}
+ {%- assign unsorted_pages_percent = unsorted_pages.size
+ | times: 100 | divided_by: title_pages_size -%}
+ {%- if unsorted_pages_percent > 50 -%}
+ {%- assign sorted_pages = "" | split: "" -%}
+ {%- for item in title_pages -%}
+ {%- if item.nav_exclude != true or item.parent -%}
+ {%- assign sorted_pages = sorted_pages | push: item -%}
+ {%- endif -%}
+ {%- endfor -%}
+ {%- assign title_pages = sorted_pages -%}
+ {%- endif -%}
+{%- endunless -%}
{%- assign nav_order_pages = title_pages
| where_exp: "item", "item.nav_order != nil" -%}
--
GitLab