From 551398f92fc125f4692e49d636d2625ca2bf3819 Mon Sep 17 00:00:00 2001
From: Simone <26844016+simonebortolin@users.noreply.github.com>
Date: Sat, 31 Dec 2022 09:51:54 +0100
Subject: [PATCH] Standardize
SCSS:`declaration-block-no-redundant-longhand-properties` (#1102)
* Fix stylelint "declaration-block-no-redundant-longhand-properties"
Co-authored-by: Matt Wang <matt@matthewwang.me>
---
.stylelintrc.json | 1 -
_sass/buttons.scss | 5 +----
_sass/labels.scss | 5 +----
_sass/layout.scss | 3 +--
_sass/navigation.scss | 18 ++++--------------
_sass/search.scss | 19 ++++---------------
_sass/tables.scss | 5 +----
7 files changed, 12 insertions(+), 44 deletions(-)
diff --git a/.stylelintrc.json b/.stylelintrc.json
index dfe788c7..0a93d257 100644
--- a/.stylelintrc.json
+++ b/.stylelintrc.json
@@ -14,7 +14,6 @@
"prettier/prettier": true,
"alpha-value-notation": null,
"color-function-notation": null,
- "declaration-block-no-redundant-longhand-properties": null,
"no-descending-specificity": null,
"scss/no-global-function-names": null
}
diff --git a/_sass/buttons.scss b/_sass/buttons.scss
index 1641deb5..cd6177e8 100644
--- a/_sass/buttons.scss
+++ b/_sass/buttons.scss
@@ -4,10 +4,7 @@
.btn {
display: inline-block;
box-sizing: border-box;
- padding-top: 0.3em;
- padding-right: 1em;
- padding-bottom: 0.3em;
- padding-left: 1em;
+ padding: 0.3em 1em;
margin: 0;
font-family: inherit;
font-size: inherit;
diff --git a/_sass/labels.scss b/_sass/labels.scss
index c8731bb3..a1b63c94 100644
--- a/_sass/labels.scss
+++ b/_sass/labels.scss
@@ -3,10 +3,7 @@
.label,
.label-blue {
display: inline-block;
- padding-top: 0.16em;
- padding-right: 0.56em;
- padding-bottom: 0.16em;
- padding-left: 0.56em;
+ padding-top: 0.16em 0.56em;
margin-right: $sp-2;
margin-left: $sp-2;
color: $white;
diff --git a/_sass/layout.scss b/_sass/layout.scss
index fd5f263e..a753866a 100644
--- a/_sass/layout.scss
+++ b/_sass/layout.scss
@@ -7,11 +7,10 @@
background-color: $sidebar-color;
@include mq(md) {
- flex-wrap: nowrap;
+ flex-flow: column nowrap;
position: fixed;
width: $nav-width-md;
height: 100%;
- flex-direction: column;
border-right: $border $border-color;
align-items: flex-end;
}
diff --git a/_sass/navigation.scss b/_sass/navigation.scss
index 8768f142..011a32ee 100644
--- a/_sass/navigation.scss
+++ b/_sass/navigation.scss
@@ -73,19 +73,13 @@
width: $nav-list-item-height-sm;
height: $nav-list-item-height-sm;
- padding-top: #{$nav-list-item-height-sm * 0.25};
- padding-right: #{$nav-list-item-height-sm * 0.25};
- padding-bottom: #{$nav-list-item-height-sm * 0.25};
- padding-left: #{$nav-list-item-height-sm * 0.25};
+ padding: #{$nav-list-item-height-sm * 0.25};
color: $link-color;
@include mq(md) {
width: $nav-list-item-height;
height: $nav-list-item-height;
- padding-top: #{$nav-list-item-height * 0.25};
- padding-right: #{$nav-list-item-height * 0.25};
- padding-bottom: #{$nav-list-item-height * 0.25};
- padding-left: #{$nav-list-item-height * 0.25};
+ padding: #{$nav-list-item-height * 0.25};
}
&:hover {
@@ -138,10 +132,7 @@
}
.nav-category {
- padding-top: $sp-2;
- padding-right: $gutter-spacing-sm;
- padding-bottom: $sp-2;
- padding-left: $gutter-spacing-sm;
+ padding: $sp-2 $gutter-spacing-sm;
font-weight: 600;
text-align: start;
text-transform: uppercase;
@@ -149,8 +140,7 @@
@include fs-2;
@include mq(md) {
- padding-right: $gutter-spacing;
- padding-left: $gutter-spacing;
+ padding: $sp-2 $gutter-spacing;
margin-top: $gutter-spacing-sm;
text-align: start;
diff --git a/_sass/search.scss b/_sass/search.scss
index 29efddec..2c46e8cd 100644
--- a/_sass/search.scss
+++ b/_sass/search.scss
@@ -41,10 +41,7 @@
position: absolute;
width: 100%;
height: 100%;
- padding-top: $sp-2;
- padding-right: $gutter-spacing-sm;
- padding-bottom: $sp-2;
- padding-left: #{$gutter-spacing-sm + $sp-5};
+ padding: $sp-2 $gutter-spacing-sm $sp-2 #{$gutter-spacing-sm + $sp-5};
font-size: 16px;
color: $body-text-color;
background-color: $search-background-color;
@@ -55,9 +52,7 @@
border-radius: 0;
@include mq(md) {
- padding-top: $gutter-spacing-sm;
- padding-bottom: $gutter-spacing-sm;
- padding-left: #{$gutter-spacing + $sp-5};
+ padding: $sp-2 $gutter-spacing-sm $sp-2 #{$gutter-spacing + $sp-5};
font-size: 14px;
background-color: $body-background-color;
transition: padding-left linear #{$transition-duration * 0.5};
@@ -128,10 +123,7 @@
.search-result {
display: block;
- padding-top: $sp-1;
- padding-right: $sp-3;
- padding-bottom: $sp-1;
- padding-left: $sp-3;
+ padding-top: $sp-1 $sp-3;
&:hover,
&.active {
@@ -224,10 +216,7 @@
}
.search-no-result {
- padding-top: $sp-2;
- padding-right: $sp-3;
- padding-bottom: $sp-2;
- padding-left: $sp-3;
+ padding: $sp-2 $sp-3;
@include fs-3;
}
diff --git a/_sass/tables.scss b/_sass/tables.scss
index 18d337a3..db8f9de7 100644
--- a/_sass/tables.scss
+++ b/_sass/tables.scss
@@ -22,10 +22,7 @@ td {
@include fs-3;
min-width: 120px;
- padding-top: $sp-2;
- padding-right: $sp-3;
- padding-bottom: $sp-2;
- padding-left: $sp-3;
+ padding: $sp-2 $sp-3;
background-color: $table-background-color;
border-bottom: $border rgba($border-color, 0.5);
border-left: $border $border-color;
--
GitLab