From 7c124a210a5303e99556de0ee54d79b6d8f6d3b8 Mon Sep 17 00:00:00 2001
From: Peter Mosses <18308236+pdmosses@users.noreply.github.com>
Date: Fri, 14 Oct 2022 22:15:25 +0200
Subject: [PATCH] Fix incorrect disambiguation in generated TOCs (#999)
The regression tests in https://just-the-docs.github.io/just-the-docs-tests/navigation/grandparent/index/ include a section "A grandchild with the same parent title as a child or top-level page". Its last item fails, as can currently be seen at https://just-the-docs.github.io/just-the-docs-tests/navigation/grandparent/f/ : the first occurrence of `G` links to the grandchild of `E`., and shouldn't be included.
The regression can be fixed by changing `where: "grand_parent", page.parent` to `where_exp: "item", "item.grand_parent == page.parent"`. This should be apparent when running the regressions tests with this PR branch as remote theme.
The two filters give the same results in Jekyll 4, but not in Jekyll 3. It seems that this was overlooked because the sanity-testing of v0.4.0.rc3 was inadvertently using Jekyll 4.2.2.
---
_includes/nav.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/_includes/nav.html b/_includes/nav.html
index 93ab7be3..c3d6782d 100644
--- a/_includes/nav.html
+++ b/_includes/nav.html
@@ -227,7 +227,7 @@
{%- if page.has_children == true and page.has_toc != false -%}
{%- assign toc_list = pages_list
| where: "parent", page.title
- | where: "grand_parent", page.parent -%}
+ | where_exp: "item", "item.grand_parent == page.parent" -%}
{%- if page.child_nav_order == "desc" -%}
{%- assign toc_list = toc_list | reverse -%}
{%- endif -%}
--
GitLab