Skip to content
Snippets Groups Projects
Commit f2e35db5 authored by Paul McCarthy's avatar Paul McCarthy :mountain_bicyclist:
Browse files

BF: Missing normalisation step in decompose

parent 86c0fdb0
No related branches found
No related tags found
No related merge requests found
...@@ -214,6 +214,7 @@ def decompose(xform, angles=True): ...@@ -214,6 +214,7 @@ def decompose(xform, angles=True):
# The process of finding the scaling factors and shear parameters # The process of finding the scaling factors and shear parameters
# is interleaved. First, find s_x = |M'_1|. # is interleaved. First, find s_x = |M'_1|.
sx = np.sqrt(np.dot(M1, M1)) sx = np.sqrt(np.dot(M1, M1))
M1 /= sx
# Then, compute an initial value for the xy shear factor, # Then, compute an initial value for the xy shear factor,
# s_xy = M'_1 * M'_2. (this is too large by the y scaling factor). # s_xy = M'_1 * M'_2. (this is too large by the y scaling factor).
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment