BF: make fslcomplex preserve image orientation

This MR fixes fslcomplex so that output files have the same orientation information as (complex) input files. The read_complexvolume function reads in a complex64 image as separate real/imaginary volume<float> objects, but was only performing a L/R flip, and was not actually setting header information in the loaded volumes.

Fixes avwutils#5 (closed)

mentioned in merge request pyfeeds-tests!46 (merged)

added 1 commit

• b932d06d - RF: remove isComplex check in for-loop conditionals

Compare with previous version

mentioned in issue avwutils#5 (closed)

changed the description

These changes look like they don't do the makeradiological swap - this would be a change in behaviour and potentially interact with the save_complexvolume swap back?

added 2 commits

• 33a28d4f - BF: Accidentally removed l/r flips in read_complexvolume
• 397d9a14 - TEST: Re-arrange test code, and add unit tests for read/save_complexvolume

Compare with previous version

@mwebster you're right - I had thought that I'd added a L/R flip in. Fixed now. I've also added some C++ unit tests to check that the l/r flip is being applied correctly for neurologically stored images, and that the s/qforms and codes are preserved when reading/saving/re-reading a complex volume.

In fact, the original code was not performing the L/R flip correctly - the volume::makeradiological does its own affine check, and only performs the flip if needed. But because the realvols / imagvols header information was not set, this check was not valid.

merged