MNT: Updates to conda recipe
Hi Istvan,
Would you be able to update the TIRL conda recipe to fix a few small issues for getting TIRL into FSL 6.0.4:
-
Link to, rather than move, the TIRL data directory from
$FSLDIR
- the root conda environment will cache the un-tarred TIRL package, and modifying it by removing the data directory can cause conda to complain about it being corrupted. -
Do not invoke
python
orconda
frompost-link.sh
, as there is no guarantee that they are thepython
/conda
commands associated with the environment into which TIRL is being installed. Furthermore, runningpython -c "import tirl..."
may have unintended side effects*. I've replaced yourpython
invocations withsed
, and have removed the line which sets up the$TIRLHOME
environment variable. From what I could see,$TIRLHOME
is not actually used anywhere, and it would be easiest if we could just omit it for the time being. -
Clean up installed data in the
pre-unlink.sh
script. -
Renamed the
conda-recipies
directory, to get rid of the typo in the name.
Thanks!
*For example: https://git.fmrib.ox.ac.uk/ihuszar/tirl/-/blob/master/src/tirl/settings.py#L26 . As an aside, I would suggest that you use the built-in tempfile
module, rather than hard-coding /tmp/TIRLTWD
, because the temporary directory is not guaranteed to be located at /tmp/
, so this call may not succceed in all environments.