Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T tirl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Istvan N. Huszar, MD
  • tirl
  • Merge requests
  • !1
The source project of this merge request has been removed.

MNT: Updates to conda recipe

Closed Paul McCarthy requested to merge (removed):mnt/conda-recipe into master Jul 28, 2020
  • Overview 1
  • Pipelines 0
  • Changes 6

Hi Istvan,

Would you be able to update the TIRL conda recipe to fix a few small issues for getting TIRL into FSL 6.0.4:

  1. Link to, rather than move, the TIRL data directory from $FSLDIR - the root conda environment will cache the un-tarred TIRL package, and modifying it by removing the data directory can cause conda to complain about it being corrupted.

  2. Do not invoke python or conda from post-link.sh, as there is no guarantee that they are the python/conda commands associated with the environment into which TIRL is being installed. Furthermore, running python -c "import tirl..." may have unintended side effects*. I've replaced your python invocations with sed, and have removed the line which sets up the $TIRLHOME environment variable. From what I could see, $TIRLHOME is not actually used anywhere, and it would be easiest if we could just omit it for the time being.

  3. Clean up installed data in the pre-unlink.sh script.

  4. Renamed the conda-recipies directory, to get rid of the typo in the name.

Thanks!

*For example: https://git.fmrib.ox.ac.uk/ihuszar/tirl/-/blob/master/src/tirl/settings.py#L26 . As an aside, I would suggest that you use the built-in tempfile module, rather than hard-coding /tmp/TIRLTWD, because the temporary directory is not guaranteed to be located at /tmp/, so this call may not succceed in all environments.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mnt/conda-recipe