Skip to content
Snippets Groups Projects
Commit f2da12d6 authored by Paul McCarthy's avatar Paul McCarthy
Browse files

Fixed histogram display range reset on 3D histogram overlay

enabling. Was caused by bug in the props bindable module.
parent aa4f3404
No related branches found
No related tags found
No related merge requests found
...@@ -119,6 +119,8 @@ class DisplayContext(props.SyncableHasProperties): ...@@ -119,6 +119,8 @@ class DisplayContext(props.SyncableHasProperties):
dParent = None dParent = None
else: else:
dParent = self.getParent().getDisplay(overlay, overlayType) dParent = self.getParent().getDisplay(overlay, overlayType)
if overlayType is None:
overlayType = dParent.overlayType
display = fsldisplay.Display(overlay, display = fsldisplay.Display(overlay,
self.__overlayList, self.__overlayList,
......
...@@ -162,11 +162,8 @@ class HistogramSeries(plotpanel.DataSeries): ...@@ -162,11 +162,8 @@ class HistogramSeries(plotpanel.DataSeries):
self.overlayList.append(self.overlay3D) self.overlayList.append(self.overlay3D)
print 'Appended new mask overlay'
opts = self.displayCtx.getOpts(self.overlay3D, overlayType='mask') opts = self.displayCtx.getOpts(self.overlay3D, overlayType='mask')
print 'Got overlay options'
opts.bindProps('volume', self) opts.bindProps('volume', self)
opts.bindProps('colour', self) opts.bindProps('colour', self)
opts.bindProps('threshold', self, 'dataRange') opts.bindProps('threshold', self, 'dataRange')
...@@ -250,6 +247,7 @@ class HistogramPanel(plotpanel.PlotPanel): ...@@ -250,6 +247,7 @@ class HistogramPanel(plotpanel.PlotPanel):
"""De-registers property listeners. """ """De-registers property listeners. """
plotpanel.PlotPanel.destroy(self) plotpanel.PlotPanel.destroy(self)
self.removeGlobalListener(self._name)
self._overlayList.removeListener('overlays', self._name) self._overlayList.removeListener('overlays', self._name)
self._displayCtx .removeListener('selectedOverlay', self._name) self._displayCtx .removeListener('selectedOverlay', self._name)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment