Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
F
fslpy
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Container Registry
Model registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Michiel Cottaar
fslpy
Commits
f2da12d6
Commit
f2da12d6
authored
9 years ago
by
Paul McCarthy
Browse files
Options
Downloads
Patches
Plain Diff
Fixed histogram display range reset on 3D histogram overlay
enabling. Was caused by bug in the props bindable module.
parent
aa4f3404
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
fsl/fslview/displaycontext/displaycontext.py
+2
-0
2 additions, 0 deletions
fsl/fslview/displaycontext/displaycontext.py
fsl/fslview/views/histogrampanel.py
+1
-3
1 addition, 3 deletions
fsl/fslview/views/histogrampanel.py
with
3 additions
and
3 deletions
fsl/fslview/displaycontext/displaycontext.py
+
2
−
0
View file @
f2da12d6
...
@@ -119,6 +119,8 @@ class DisplayContext(props.SyncableHasProperties):
...
@@ -119,6 +119,8 @@ class DisplayContext(props.SyncableHasProperties):
dParent
=
None
dParent
=
None
else
:
else
:
dParent
=
self
.
getParent
().
getDisplay
(
overlay
,
overlayType
)
dParent
=
self
.
getParent
().
getDisplay
(
overlay
,
overlayType
)
if
overlayType
is
None
:
overlayType
=
dParent
.
overlayType
display
=
fsldisplay
.
Display
(
overlay
,
display
=
fsldisplay
.
Display
(
overlay
,
self
.
__overlayList
,
self
.
__overlayList
,
...
...
This diff is collapsed.
Click to expand it.
fsl/fslview/views/histogrampanel.py
+
1
−
3
View file @
f2da12d6
...
@@ -162,11 +162,8 @@ class HistogramSeries(plotpanel.DataSeries):
...
@@ -162,11 +162,8 @@ class HistogramSeries(plotpanel.DataSeries):
self
.
overlayList
.
append
(
self
.
overlay3D
)
self
.
overlayList
.
append
(
self
.
overlay3D
)
print
'
Appended new mask overlay
'
opts
=
self
.
displayCtx
.
getOpts
(
self
.
overlay3D
,
overlayType
=
'
mask
'
)
opts
=
self
.
displayCtx
.
getOpts
(
self
.
overlay3D
,
overlayType
=
'
mask
'
)
print
'
Got overlay options
'
opts
.
bindProps
(
'
volume
'
,
self
)
opts
.
bindProps
(
'
volume
'
,
self
)
opts
.
bindProps
(
'
colour
'
,
self
)
opts
.
bindProps
(
'
colour
'
,
self
)
opts
.
bindProps
(
'
threshold
'
,
self
,
'
dataRange
'
)
opts
.
bindProps
(
'
threshold
'
,
self
,
'
dataRange
'
)
...
@@ -250,6 +247,7 @@ class HistogramPanel(plotpanel.PlotPanel):
...
@@ -250,6 +247,7 @@ class HistogramPanel(plotpanel.PlotPanel):
"""
De-registers property listeners.
"""
"""
De-registers property listeners.
"""
plotpanel
.
PlotPanel
.
destroy
(
self
)
plotpanel
.
PlotPanel
.
destroy
(
self
)
self
.
removeGlobalListener
(
self
.
_name
)
self
.
_overlayList
.
removeListener
(
'
overlays
'
,
self
.
_name
)
self
.
_overlayList
.
removeListener
(
'
overlays
'
,
self
.
_name
)
self
.
_displayCtx
.
removeListener
(
'
selectedOverlay
'
,
self
.
_name
)
self
.
_displayCtx
.
removeListener
(
'
selectedOverlay
'
,
self
.
_name
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment